Skip to content

Commit

Permalink
GH-23995: [C#] Make PrimitiveArrayBuilder constructor public (#44596)
Browse files Browse the repository at this point in the history
Fixes #23995.

Making these constructors `public` allows for writing custom builders.

### Rationale for this change

Allows for writing custom builders.

### What changes are included in this PR?

Only change of visibility on the default constructors of `PrimitiveArrayBuilder`.

### Are these changes tested?

There is not much to test :)

### Are there any user-facing changes?

See above.

* GitHub Issue: #23995

Authored-by: Benedikt Reinartz <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
  • Loading branch information
filmor authored Nov 5, 2024
1 parent 4274db8 commit 46e7f38
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public abstract class PrimitiveArrayBuilder<TFrom, TTo, TArray, TBuilder> : IArr

public int Length => ArrayBuilder.Length;

internal PrimitiveArrayBuilder(IArrowArrayBuilder<TTo, TArray, IArrowArrayBuilder<TArray>> builder)
public PrimitiveArrayBuilder(IArrowArrayBuilder<TTo, TArray, IArrowArrayBuilder<TArray>> builder)
{
ArrayBuilder = builder ?? throw new ArgumentNullException(nameof(builder));
}
Expand Down Expand Up @@ -110,7 +110,7 @@ public abstract class PrimitiveArrayBuilder<T, TArray, TBuilder> : IArrowArrayBu
public int Length => ValueBuffer.Length;
protected int NullCount => ValidityBuffer.UnsetBitCount;

internal PrimitiveArrayBuilder()
public PrimitiveArrayBuilder()
{
ValueBuffer = new ArrowBuffer.Builder<T>();
ValidityBuffer = new ArrowBuffer.BitmapBuilder();
Expand Down

0 comments on commit 46e7f38

Please sign in to comment.