Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
wgtmac committed Nov 17, 2024
1 parent f4d8380 commit c3461b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 1 addition & 2 deletions cpp/src/parquet/page_index.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "parquet/encryption/type_fwd.h"
#include "parquet/type_fwd.h"
#include "parquet/types.h"
#include "size_statistics.h"

#include <optional>
#include <vector>
Expand Down Expand Up @@ -283,7 +282,7 @@ class PARQUET_EXPORT ColumnIndexBuilder {
/// \param stats Page statistics in the encoded form.
/// \param size_stats Size statistics of the page if available.
virtual void AddPage(const EncodedStatistics& stats,
const SizeStatistics& size_stats = SizeStatistics{}) = 0;
const SizeStatistics& size_stats) = 0;

/// \brief Complete the column index.
///
Expand Down
5 changes: 3 additions & 2 deletions cpp/src/parquet/page_index_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ TEST(PageIndex, WriteColumnIndexWithCorruptedStats) {
ColumnDescriptor descr(schema::Int32("c1"), /*max_definition_level=*/1, 0);
auto builder = ColumnIndexBuilder::Make(&descr);
for (const auto& stats : page_stats) {
builder->AddPage(stats);
builder->AddPage(stats, SizeStatistics());
}
ASSERT_NO_THROW(builder->Finish());
ASSERT_EQ(nullptr, builder->Build());
Expand Down Expand Up @@ -784,7 +784,8 @@ class PageIndexBuilderTest : public ::testing::Test {
for (int column = 0; column < num_columns; ++column) {
if (static_cast<size_t>(column) < page_stats[row_group].size()) {
auto column_index_builder = builder->GetColumnIndexBuilder(column);
ASSERT_NO_THROW(column_index_builder->AddPage(page_stats[row_group][column]));
ASSERT_NO_THROW(
column_index_builder->AddPage(page_stats[row_group][column], {}));
ASSERT_NO_THROW(column_index_builder->Finish());
}

Expand Down

0 comments on commit c3461b6

Please sign in to comment.