Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archery][Dev] Update archery to support same setuptools-scm version than pyarrow #43114

Closed
raulcd opened this issue Jul 2, 2024 · 2 comments

Comments

@raulcd
Copy link
Member

raulcd commented Jul 2, 2024

Describe the enhancement requested

Trying to use archery with the latest setuptools-scm which is required for pyarrow fails.
For the release I tried to submit some jobs with:

archery crossbow submit --job-prefix maint-17.0.0-nightly-tests --group nightly-tests --arrow-branch maint-17.0.0 --no-fetch

and I got the following failure

DEBUG:archery:Executing `['git', '-C', '/home/raulcd/code/arrow', 'rev-parse', '--show-toplevel']`
Traceback (most recent call last):
  File "/home/raulcd/code/pyarrow-dev/bin/archery", line 33, in <module>
    sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/raulcd/code/pyarrow-dev/lib/python3.10/site-packages/click/decorators.py", line 38, in new_func
    return f(get_current_context().obj, *args, **kwargs)
  File "/home/raulcd/code/arrow/dev/archery/archery/crossbow/cli.py", line 131, in submit
    target = Target.from_repo(arrow, remote=arrow_remote, branch=arrow_branch,
  File "/home/raulcd/code/arrow/dev/archery/archery/crossbow/core.py", line 837, in from_repo
    version = get_version(repo.path)
  File "/home/raulcd/code/arrow/dev/archery/archery/crossbow/core.py", line 754, in get_version
    version = parse_git_version(root, **kwargs)
TypeError: parse() missing 1 required positional argument: 'config'

This was in the virtualenv I use for pyarrow where we require setuptools-scm==8.1.0. I've changed to a different virtualenv that uses setuptools-scm==7.1.0 and worked successfully.

We should be able to use the same version of setuptools-scm for archery and pyarrow

Component(s)

Archery, Developer Tools

@llama90
Copy link
Contributor

llama90 commented Jul 5, 2024

take

kou pushed a commit that referenced this issue Jul 12, 2024
### Rationale for this change

The update to `setuptools-scm` version 8.0.0 or higher ensures compatibility for Archery.

### What changes are included in this PR?

- Added `Configuration` objects to handle necessary parameters (`get_describe_command`)
- Fixed the `parse_git_version` function to align with the new version of `setuptools_scm`
- Updated `setuptools_scm` requirement to version 8.0.0 or higher

### Are these changes tested?

Yes, tested by CI.

### Are there any user-facing changes?

No.

* GitHub Issue: #43114

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Jul 12, 2024

Issue resolved by pull request 43156
#43156

@kou kou added this to the 18.0.0 milestone Jul 12, 2024
@kou kou closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants