-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43114: [Archery][Dev] Support setuptools-scm >= 8.0.0 #43156
Conversation
|
get_version
for setuptools-scm > 8.x
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been taking a look onto the changes for setuptools_scm
and the change looks good to me: https://github.com/pypa/setuptools_scm/blob/main/src/setuptools_scm/git.py#L203-L217
The upgrade of the dependency also LGTM as this is the only place were we seem to be using it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2d4c80b. There were 44 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The update to
setuptools-scm
version 8.0.0 or higher ensures compatibility for Archery.What changes are included in this PR?
Configuration
objects to handle necessary parameters (get_describe_command
)parse_git_version
function to align with the new version ofsetuptools_scm
setuptools_scm
requirement to version 8.0.0 or higherAre these changes tested?
Yes, tested by CI.
Are there any user-facing changes?
No.