Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43114: [Archery][Dev] Support setuptools-scm >= 8.0.0 #43156

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

llama90
Copy link
Contributor

@llama90 llama90 commented Jul 5, 2024

Rationale for this change

The update to setuptools-scm version 8.0.0 or higher ensures compatibility for Archery.

What changes are included in this PR?

  • Added Configuration objects to handle necessary parameters (get_describe_command)
  • Fixed the parse_git_version function to align with the new version of setuptools_scm
  • Updated setuptools_scm requirement to version 8.0.0 or higher

Are these changes tested?

Yes, tested by CI.

Are there any user-facing changes?

No.

Copy link

github-actions bot commented Jul 5, 2024

⚠️ GitHub issue #43114 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jul 5, 2024
@llama90 llama90 changed the title GH-43114: [Archery][Dev] Update get_version for setuptools-scm > 8.x GH-43114: [Archery][Dev] Support setuptools-scm >= 8.0.0 Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

⚠️ GitHub issue #43114 has been automatically assigned in GitHub to PR creator.

1 similar comment
Copy link

github-actions bot commented Jul 5, 2024

⚠️ GitHub issue #43114 has been automatically assigned in GitHub to PR creator.

@llama90
Copy link
Contributor Author

llama90 commented Jul 12, 2024

@raulcd @kou Could you review this when your free time? Thank you.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been taking a look onto the changes for setuptools_scm and the change looks good to me: https://github.com/pypa/setuptools_scm/blob/main/src/setuptools_scm/git.py#L203-L217
The upgrade of the dependency also LGTM as this is the only place were we seem to be using it

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 12, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 2d4c80b into apache:main Jul 12, 2024
9 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jul 12, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 12, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2d4c80b.

There were 44 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants