Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Dev][Docs] Consider updating all references to "docker-compose" with "docker compose" #43570

Closed
amoeba opened this issue Aug 5, 2024 · 2 comments
Closed

[CI][Dev][Docs] Consider updating all references to "docker-compose" with "docker compose" #43570

amoeba opened this issue Aug 5, 2024 · 2 comments
Assignees
@amoeba
Labels
Component: Continuous Integration Component: Developer Tools Type: enhancement
Milestone
19.0.0

Comments

@amoeba
Copy link
Member

amoeba commented Aug 5, 2024

Describe the enhancement requested

Arrow's CI and documentation reference docker-compose in many places which is the old V1 way of calling into Docker Compose, see https://docs.docker.com/compose/migrate/ for more background on docker-compose vs docker compose. It should be safe to update all references to docker-compose to use the current docker compose.

Note: What prompted this issue is that CI just started failing due to the GitHub Actions runners not being able to find docker-compose. See 1, 2. This was caused by GHA runner image release 20240804 finally removing docker-compose.

There's already a minor PR updating CI and it would be good to follow up with a PR updating references everywhere else as I think (1) most developer systems should have V2 now and (2) V1 may slowly get phased out of package managers.

Component(s)

Continuous Integration, Developer Tools
@amoeba
Copy link
Member Author

amoeba commented Aug 5, 2024

I'm looking at this today. We might be able to deprecate ARCHERY_USE_DOCKER_CLI and the related stuff in archery like using_docker_cli.

@amoeba amoeba mentioned this issue Aug 6, 2024
Merged
kou added a commit that referenced this issue Nov 15, 2024
@amoeba @kou
GH-43570: [CI][Dev][Docs] Update references to "docker-compose" with …
736d706 
…"docker compose" (#43575)

### Rationale for this change

This is a follow-on to #43566 which was merged earlier today. See #43570 for more detail on the entire set of changes.

### What changes are included in this PR?

- Replace instances where we call or document calling `docker-compose` with `docker compose`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

This PR includes the require user-facing changes to document things.
* GitHub Issue: #43570

Lead-authored-by: Bryce Mecum <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 19.0.0 milestone Nov 15, 2024
@kou
Copy link
Member

kou commented Nov 15, 2024

Issue resolved by pull request 43575
#43575

@kou kou closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoeba amoeba

Labels
Component: Continuous Integration Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@amoeba @kou