-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43570: [CI][Dev][Docs] Update references to "docker-compose" with "docker compose" #43575
Conversation
|
Note that more Archery changes were done in PR #43586. |
@amoeba Do you want to revive this PR? |
Yeah. Let me see what's needed to close this out now. |
c69c1d8
to
b38aee6
Compare
I rebased and went through the repo again to find any instances that needed attention. Waiting for CI but I think this is ready for a review. |
Pushed one commit to fix the archery tests. |
The three CI failures don't look related to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Sutou Kouhei <[email protected]>
@kou 's suggestion encouraged me to do a more serious pass, trying to use "Docker Compose" everywhere I saw we were referring to the product/software rather than a shell command. See 71a365a. Some calls were subjective, though I think the most important thing has been done here (change @pitrou do you want to take a last look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd wait for @kou 's approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 736d706. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This is a follow-on to #43566 which was merged earlier today. See #43570 for more detail on the entire set of changes.
What changes are included in this PR?
docker-compose
withdocker compose
.Are these changes tested?
Yes.
Are there any user-facing changes?
This PR includes the require user-facing changes to document things.