-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs #35811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Sutou Kouhei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Benchmark runs are scheduled for baseline = 1951a1a and contender = 431785f. 431785f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
We are duplicating the Closes issue_id comment on PRs adding it to both the PR body and a comment. There was some discussion to remove it from the comment.
What changes are included in this PR?
Remove adding extra comment to PR and check whether
Closes XXX
was already added on the body instead of checking comment.Are these changes tested?
Yes, I have tested on my fork, see this PR: raulcd#79
Are there any user-facing changes?
No