-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [FlightRPC][C++][Python][Docs] Minor tweaks to docstrings #36900
Conversation
"Terminate" isn't used elsewhere so I think it makes sense to de-introduce this word
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5e1c112. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…che#36900) ### Rationale for this change Improves language surrounding Flight Shutdown/Wait/Serve. ### What changes are included in this PR? Just docstring tweaks. ### Are these changes tested? No tests, just docstrings. ### Are there any user-facing changes? n/a Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…che#36900) ### Rationale for this change Improves language surrounding Flight Shutdown/Wait/Serve. ### What changes are included in this PR? Just docstring tweaks. ### Are these changes tested? No tests, just docstrings. ### Are there any user-facing changes? n/a Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Improves language surrounding Flight Shutdown/Wait/Serve.
What changes are included in this PR?
Just docstring tweaks.
Are these changes tested?
No tests, just docstrings.
Are there any user-facing changes?
n/a