Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [FlightRPC][C++][Python][Docs] Minor tweaks to docstrings #36900

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Jul 26, 2023

Rationale for this change

Improves language surrounding Flight Shutdown/Wait/Serve.

What changes are included in this PR?

Just docstring tweaks.

Are these changes tested?

No tests, just docstrings.

Are there any user-facing changes?

n/a

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 27, 2023
@kou kou changed the title MINOR: [C++][Python][Documentation] Minor tweaks to Flight docstrings MINOR: [FlightRPC][C++][Python][Docs] Minor tweaks to docstrings Jul 27, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 5e1c112 into apache:main Jul 27, 2023
34 of 36 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jul 27, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5e1c112.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
…che#36900)

### Rationale for this change

Improves language surrounding Flight Shutdown/Wait/Serve.

### What changes are included in this PR?

Just docstring tweaks.

### Are these changes tested?

No tests, just docstrings.

### Are there any user-facing changes?

n/a

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…che#36900)

### Rationale for this change

Improves language surrounding Flight Shutdown/Wait/Serve.

### What changes are included in this PR?

Just docstring tweaks.

### Are these changes tested?

No tests, just docstrings.

### Are there any user-facing changes?

n/a

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants