-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36973: [CI][Python] Archery linter integrated with flake8==6.1.0 #36976
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether we should update the pre-commit
version here:
https://github.com/apache/arrow/blob/main/.pre-commit-config.yaml#L40
Or remove it. I suppose it would use the latest one.
If we keep a version for pre-commit
maybe we should pin it on archery too?
https://github.com/apache/arrow/blob/main/dev/archery/setup.py#L32
We should keep them in sync! I can pin both to 6.1.0 for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danepitkin , looks good to me! I'll merge once CI finishes.
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 5bb53c7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
….1.0 (apache#36976) ### Rationale for this change Fix archery lint issues with new version of flake8 dependency. ### What changes are included in this PR? * Lint errors. ### Are these changes tested? Yes. ``` $ flake8 --version 6.1.0 (mccabe: 0.7.0, pycodestyle: 2.11.0, pyflakes: 3.1.0) CPython 3.11.4 on Darwin $ archery lint --python INFO:archery:Running Python formatter (autopep8) INFO:archery:Running Python linter (flake8) INFO:archery:Running Cython linter (cython-lint) $ ``` ### Are there any user-facing changes? No * Closes: apache#36973 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
Fix archery lint issues with new version of flake8 dependency.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No