GH-37253: [MATLAB] Add test cases which verify that the NumFields, BitWidth, and ID properties can not be modified to hFixedWidth test class
#37316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superclass. 2. Fix typo: schema -> type.
github-actions
bot
added
Component: MATLAB
awaiting committer review
|
+1 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit faa4652. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…lds`, `BitWidth`, and `ID` properties can not be modified to `hFixedWidth` test class (apache#37316) ### Rationale for this change As @ sgilmore10 pointed out in apache#37250 (comment), it makes sense to move the tests which verify that the `NumFields`, `BitWidth`, and `ID` properties cannot be set into the `hFixedWidthType` superclass, rather than having these tests implemented in `tTime32Type` and `tTime64Type`, since they are common to all fixed width types. ### What changes are included in this PR? 1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`. 2. Fixed typo in `tTime32Type` and `tTime64Type`. Changed variable name `schema` to `type`. ### Are these changes tested? Yes. 1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`. ### Are there any user-facing changes? No. This pull request only modifies tests. * Closes: apache#37253 Authored-by: Kevin Gurney <[email protected]> Signed-off-by: Kevin Gurney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As @sgilmore10 pointed out in #37250 (comment), it makes sense to move the tests which verify that the
NumFields,BitWidth, andIDproperties cannot be set into thehFixedWidthTypesuperclass, rather than having these tests implemented intTime32TypeandtTime64Type, since they are common to all fixed width types.What changes are included in this PR?
BitWidth,NumFields, andIDproperties cannot be set out of thetTime32TypeandtTime64Typeclasses and into the superclasshFixedWidthType.tTime32TypeandtTime64Type. Changed variable nameschematotype.Are these changes tested?
Yes.
BitWidth,NumFields, andIDproperties cannot be set out of thetTime32TypeandtTime64Typeclasses and into the superclasshFixedWidthType.Are there any user-facing changes?
No.
This pull request only modifies tests.
NumFields,BitWidth, andIDproperties can not be modified tohFixedWidthtest class #37253