Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37340: [MATLAB] The column(index) method of arrow.tabular.RecordBatch errors if index refers to an arrow.array.Time32Array column #37347

Merged
merged 9 commits into from
Aug 23, 2023
Merged

GH-37340: [MATLAB] The column(index) method of arrow.tabular.RecordBatch errors if index refers to an arrow.array.Time32Array column #37347

merged 9 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Add Time32 switch case to arrow::matlab::array::proxy::wrap()

    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    09650e2 View commit details
    Browse the repository at this point in the history

  2. Add test utilty that creates a cell array containing all concrete sub… 

    …classes of arrow.array.Array
    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ef3a48c View commit details
    Browse the repository at this point in the history

  3. Add second output to createSupportedArrays containing the original ma… 

    …tlab data
    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7c908bb View commit details
    Browse the repository at this point in the history

  4. Rename createSupportedArrays to createAllSupportedArrayTypes

    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    dea8eb8 View commit details
    Browse the repository at this point in the history

  5. Re-write createAllSupportedArrayTypes.m to dynamically generate the l… 

    …ist of concrete arrow.array.Array subclasses
    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0529a6f View commit details
    Browse the repository at this point in the history

  6. Update fromArrays tests to verify Time32Arrays are supported

    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    edcd266 View commit details
    Browse the repository at this point in the history

  7. Update createAllSupportedArrayTypes H1 line

    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7a7d862 View commit details
    Browse the repository at this point in the history

  8. Update test comment

    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6d373ae View commit details
    Browse the repository at this point in the history

  9. Added comment about removing Abstract classes from the subclass list

    @sgilmore10
    sgilmore10 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    70691a5 View commit details
    Browse the repository at this point in the history