MINOR: [Python][Docs] Add examples for MapArray.from_arrays

[slobodan-ilic]

Rationale for this change

This PR enriched the MapArray.from_arrays with some nice examples. The examples are from the real-world scenario of working with survey data (scaled down, of course).

What changes are included in this PR?

The only change that this PR presents is to the docstring of the MapArray.from_arrays function.

Are these changes tested?

Does not apply

Are there any user-facing changes?

Yes, the docstring of the MapArray.from_arrays function.

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - How to contribute patches

[danepitkin]

Great example! I left a few small comments, let me know what you think. I thought it might be clearer to explicitly state that the numpy representation is there to visualize the data that we will put in the MapArray.

[slobodan-ilic]

Great example! I left a few small comments, let me know what you think. I thought it might be clearer to explicitly state that the numpy representation is there to visualize the data that we will put in the MapArray.

I accepted both of your changes. Thanks so much. I'm glad you find the example useful.

[danepitkin]

Last few comments. After that LGTM! I added a committer for final review.

[kou]

Could you read the auto generated comment?
#37656 (comment)

[AlenkaF]

Hi @slobodan-ilic and thank you for this great example!
Adding a suggestion to fix the doctest error.

We should also add an issue for the PR to be linked to, as Kou already mentioned.

[slobodan-ilic]

Hi @slobodan-ilic and thank you for this great example! Adding a suggestion to fix the doctest error.

We should also add an issue for the PR to be linked to, as Kou already mentioned.

@AlenkaF I was thinking about adding MINOR: [Python] Add examples for MapArray.from_arrays rather than creating an issue, since I believe it's a minor PR (as per second part of the autogenerated comment that @kou referenced). But if you say the issue creation is the way to go forward, please lmk and I'll do so.

[AlenkaF]

@AlenkaF I was thinking about adding MINOR: [Python] Add examples for MapArray.from_arrays rather than creating an issue, since I believe it's a minor PR (as per second part of the autogenerated comment that @kou referenced). But if you say the issue creation is the way to go forward, please lmk and I'll do so.

Yes of course, that is totally fine 👍

[raulcd]

Thanks for the contribution @slobodan-ilic !

[slobodan-ilic]

Thanks for the contribution @slobodan-ilic !

Hi @raulcd! Long time no see ❤️

[slobodan-ilic]

@AlenkaF I was thinking about adding MINOR: [Python] Add examples for MapArray.from_arrays rather than creating an issue, since I believe it's a minor PR (as per second part of the autogenerated comment that @kou referenced). But if you say the issue creation is the way to go forward, please lmk and I'll do so.

Yes of course, that is totally fine 👍

@AlenkaF I'm seeing some failures in the AppVeyor build (even after accepting your changes), and they seem unrelated to my changes. Furthermore, when I run the offending tests locally, they all pass. This seems to be one: python/pyarrow/tests/test_fs.py::test_get_file_info_with_selector. How should we resolve this?

[raulcd]

@AlenkaF I'm seeing some failures in the AppVeyor build (even after accepting your changes), and they seem unrelated to my changes.

It seems to be failing on main as seen here: https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/48012043
I've opened a different issue to track it here: #37675

[AlenkaF]

@AlenkaF I'm seeing some failures in the AppVeyor build (even after accepting your changes), and they seem unrelated to my changes. Furthermore, when I run the offending tests locally, they all pass. This seems to be one: python/pyarrow/tests/test_fs.py::test_get_file_info_with_selector. How should we resolve this?

There is already an open PR to fix this issue #37558 so you can ignore this failing build.

[danepitkin]

I'm fine leaving it the way it is! I do agree the example is more relateable this way.

[danepitkin]

Added one last suggestion, otherwise LGTM!

[slobodan-ilic]

Added one last suggestion, otherwise LGTM!

Addressed. 💯

[AlenkaF]

Thank you for you contribution @slobodan-ilic!

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 28266f1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.