-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42149: [C++] Use FetchContent for bundled ORC #43011
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
22cf96c
GH-42149: [C++] Use FetchContent for bundled ORC
kou ccd9a4c
Disable ORC on Ubuntu 20.04 because CMake is old
kou 744709f
Ensure using bundled zlib
kou 7f3a3ce
Disable unity build
kou 4adcb20
Don't prefer static library
kou e003fcc
Update comment
kou 977cce3
Don't use ORC with CentOS 7
kou e884e73
Disable ORC with old CMake
kou 53ee1d0
Disable ORC on Ubuntu 20.04
kou 0393208
Disable ORC on Ubuntu 20.04
kou 04a4125
Fix style
kou 41512bd
Add missing then
kou f037124
Adjust file list
kou c51893d
Set ZLIB::ZLIB's include directory for Emscripten
kou e5d13db
Use ARROW_ORC
kou 21943b3
Use interface library
kou 27955b4
Add missing IMPORTED
kou 5b46619
Remove needless code
kou d9ef3dc
Use ExternalProject with old CMake
kou 921b22d
Add missing libprotobuf dependency
kou 77dc35f
Require CMake 3.29+ for FetchContent
kou e0b6f52
Use CMake targets directly
kou cf33494
Add target_include_directories() again
kou 2e4112d
Disable FETCHCONTENT_FULLY_DISCONNECTED
kou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean we no longer support these legacy versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. But it seems that this is not needed with ORC 2.0.1...?
https://github.com/ursacomputing/crossbow/actions/runs/9786486604/job/27021493582 passed
Did you fix this in ORC 2.0.1? #41023 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is included: https://github.com/apache/orc/commits/v2.0.1/
Commit is apache/orc@0749e4b