Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-43228: [C++] Fix Abseil compile error on GCC 13 #43157

Merged
merged 21 commits into from
Jul 26, 2024
Merged

GH-43228: [C++] Fix Abseil compile error on GCC 13 #43157

merged 21 commits into from
Jul 26, 2024

Commits on Jul 24, 2024

  1. Include stdint on GCC13

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1cba3ce View commit details
    Browse the repository at this point in the history

  2. Lint

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7a3f0ab View commit details
    Browse the repository at this point in the history

  3. Update cpp/cmake_modules/ThirdpartyToolchain.cmake 

    Co-authored-by: Sutou Kouhei <[email protected]>
    @amol- @kou
    amol- and kou committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ed6ca2f View commit details
    Browse the repository at this point in the history

  4. Add GCC-13 test environment

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0fb0f12 View commit details
    Browse the repository at this point in the history

  5. Test in CPP env instead of R env

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6066c86 View commit details
    Browse the repository at this point in the history

  6. Build third party dependencies

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f6bccb9 View commit details
    Browse the repository at this point in the history

  7. Build only ABSL as bundled

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b0185f3 View commit details
    Browse the repository at this point in the history

  8. Profobuf must be bundled if absl is bundled

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2a11108 View commit details
    Browse the repository at this point in the history

  9. ops, typo

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d707350 View commit details
    Browse the repository at this point in the history

  10. Switch to bundled image

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d03855a View commit details
    Browse the repository at this point in the history

  11. Add ubuntu 24.04 minimal

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e757478 View commit details
    Browse the repository at this point in the history

  12. Temporarily add verbose for debugging

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a55a5d8 View commit details
    Browse the repository at this point in the history

  13. Try to disable ccache temporarily

    @amol-
    amol- committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    76c149e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Add verbose third party builds for debugging

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0fe54c2 View commit details
    Browse the repository at this point in the history

  2. Try to propagate CXX flags

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    adac2e0 View commit details
    Browse the repository at this point in the history

  3. strip spaces in flags

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1b61d03 View commit details
    Browse the repository at this point in the history

  4. Specify CMAKE_ARGS explicitly for ABSL

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d59f39b View commit details
    Browse the repository at this point in the history

  5. Remove unecessary strip

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    70e6e7d View commit details
    Browse the repository at this point in the history

  6. Remove debugging flags

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1a12ea6 View commit details
    Browse the repository at this point in the history

  7. Add tzdata-legacy

    @amol-
    amol- committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    943baa0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Remove workaround for GCS

    @amol-
    amol- committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0a6e367 View commit details
    Browse the repository at this point in the history