-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Java] Update issue management config in pom.xml #43191
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ We prefer to receive contributions in the form of GitHub pull requests. Please | |
| send pull requests against the [github.com/apache/arrow][4] repository following | ||
| the procedure below. | ||
|
|
||
| If you are looking for some ideas on what to contribute, check out the [JIRA | ||
| If you are looking for some ideas on what to contribute, check out the [GitHub | ||
| issues][3] for the Apache Arrow project. Comment on the issue and/or contact | ||
| [[email protected]](https://lists.apache.org/[email protected]) | ||
| with your questions and ideas. | ||
|
|
@@ -53,8 +53,8 @@ To contribute a patch: | |
|
|
||
| 1. Break your work into small, single-purpose patches if possible. It’s much | ||
| harder to merge in a large change with a lot of disjoint features. | ||
| 2. If one doesn't already exist, create a JIRA for your patch on the [Arrow Project | ||
| JIRA](https://issues.apache.org/jira/browse/ARROW). | ||
| 2. If one doesn't already exist, create a GitHub issue for your patch on the [Arrow Project | ||
| GitHub](https://github.com/apache/arrow/issues). | ||
| 3. Submit the patch as a GitHub pull request against the main branch. For a | ||
| tutorial, see the GitHub guides on [forking a repo](https://help.github.com/en/articles/fork-a-repo) | ||
| and [sending a pull request](https://help.github.com/en/articles/creating-a-pull-request-from-a-fork). So that your pull request syncs with the JIRA issue, prefix your pull request | ||
|
|
@@ -68,5 +68,5 @@ Thank you in advance for your contributions! | |
|
|
||
| [1]: mailto:[email protected] | ||
| [2]: https://github.com/apache/arrow/tree/main/format | ||
| [3]: https://issues.apache.org/jira/browse/ARROW | ||
| [3]: https://github.com/apache/arrow/issues | ||
| [4]: https://github.com/apache/arrow | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
maven/pom.xmlandbom/pom.xmldo not inherit from the top-levelpom.xml. you may want to change those as well (note thatmaven/pom.xmlis being removed as part of #43139)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, I didn't think to look for other uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out we don't populate
<issueManagement>in the other poms. Is it typical to add it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually not sure whether we need this?
cc @lidavidm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clearly not strictly necessary, so I'd rather we just take the update here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary but nice to have. It may be used by tools and shows up in the site generated by Maven or also accessible from websites like Maven Central.
You can check and compare the pages for arrow-memory-core and arrow-bom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
Project URLandSource Controlare also not configured correctly for maven central. Thanks for sharing.