Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-43211: [C++] Fix decimal benchmarks to avoid out-of-bounds accesses #43212

Merged
merged 1 commit into from
Jul 15, 2024
Merged

GH-43211: [C++] Fix decimal benchmarks to avoid out-of-bounds accesses #43212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cpp/src/arrow/util/decimal_benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,16 @@ static void ToString(benchmark::State& state) { // NOLINT non-const reference
state.SetItemsProcessed(state.iterations() * values.size());
}

constexpr int32_t kValueSize = 10;
constexpr int32_t kValueSize = 12;

static void BinaryCompareOp(benchmark::State& state) { // NOLINT non-const reference
std::vector<BasicDecimal128> v1, v2;
for (int x = 0; x < kValueSize; x++) {
v1.emplace_back(100 + x, 100 + x);
v2.emplace_back(200 + x, 200 + x);
}
static_assert(kValueSize % 4 == 0,
"kValueSize needs to be a multiple of 4 to avoid out-of-bounds accesses");
for (auto _ : state) {
for (int x = 0; x < kValueSize; x += 4) {
auto equal = v1[x] == v2[x];
Expand All @@ -93,7 +95,7 @@ static void BinaryCompareOp(benchmark::State& state) { // NOLINT non-const refe
benchmark::DoNotOptimize(less_than_or_equal);
auto greater_than_or_equal1 = v1[x + 2] >= v2[x + 2];
benchmark::DoNotOptimize(greater_than_or_equal1);
auto greater_than_or_equal2 = v1[x + 3] >= v1[x + 3];
auto greater_than_or_equal2 = v1[x + 3] >= v2[x + 3];
Comment on lines -96 to +98
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

benchmark::DoNotOptimize(greater_than_or_equal2);
}
}
Expand All @@ -106,6 +108,8 @@ static void BinaryCompareOpConstant(
for (int x = 0; x < kValueSize; x++) {
v1.emplace_back(100 + x, 100 + x);
}
static_assert(kValueSize % 4 == 0,
"kValueSize needs to be a multiple of 4 to avoid out-of-bounds accesses");
BasicDecimal128 constant(313, 212);
for (auto _ : state) {
for (int x = 0; x < kValueSize; x += 4) {
Expand Down Expand Up @@ -245,6 +249,8 @@ static void UnaryOp(benchmark::State& state) { // NOLINT non-const reference
v.emplace_back(100 + x, 100 + x);
}

static_assert(kValueSize % 2 == 0,
"kValueSize needs to be a multiple of 2 to avoid out-of-bounds accesses");
for (auto _ : state) {
for (int x = 0; x < kValueSize; x += 2) {
auto abs = v[x].Abs();
Expand Down Expand Up @@ -274,6 +280,8 @@ static void BinaryBitOp(benchmark::State& state) { // NOLINT non-const referenc
v2.emplace_back(200 + x, 200 + x);
}

static_assert(kValueSize % 2 == 0,
"kValueSize needs to be a multiple of 2 to avoid out-of-bounds accesses");
for (auto _ : state) {
for (int x = 0; x < kValueSize; x += 2) {
benchmark::DoNotOptimize(v1[x] |= v2[x]);
Expand Down
Loading