Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-43209: [C++] Add lint for DCHECK in public headers #43248

Merged
merged 10 commits into from
Jul 16, 2024
Merged

GH-43209: [C++] Add lint for DCHECK in public headers #43248

merged 10 commits into from
Jul 16, 2024

Commits on Jul 14, 2024

  1. Add lint for DCHECK in headers

    @zanmato1984
    zanmato1984 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e3b9617 View commit details
    Browse the repository at this point in the history

  2. Protect DCHECK macros by ifdef

    @zanmato1984
    zanmato1984 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    f007a8f View commit details
    Browse the repository at this point in the history

  3. Fix lint script

    @zanmato1984
    zanmato1984 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    b99c427 View commit details
    Browse the repository at this point in the history

  4. Replace DCHECK with ARROW_DCHECK in all public headers

    @zanmato1984
    zanmato1984 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    3d0c545 View commit details
    Browse the repository at this point in the history

  5. Format

    @zanmato1984
    zanmato1984 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e2970fd View commit details
    Browse the repository at this point in the history

  6. Revert test

    @zanmato1984
    zanmato1984 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    6338f76 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge remote-tracking branch 'origin/main' into lint-dcheck-macros

    @zanmato1984
    zanmato1984 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9410378 View commit details
    Browse the repository at this point in the history

  2. Revert some changes

    @zanmato1984
    zanmato1984 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    70858b7 View commit details
    Browse the repository at this point in the history

  3. Rename more internal headers

    @zanmato1984
    zanmato1984 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1d36148 View commit details
    Browse the repository at this point in the history

  4. Revert mis-change to acero/util.h

    @zanmato1984
    zanmato1984 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    cb0e3b1 View commit details
    Browse the repository at this point in the history