Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44393: [C++][Compute] Swizzle vector functions #44394
base: main
Are you sure you want to change the base?
GH-44393: [C++][Compute] Swizzle vector functions #44394
Changes from 33 commits
1e141d7
216e217
f3c73ea
be88f0c
b445c36
3707fa6
4e9d3a6
c4c5c41
78bb335
38bcc5d
d88877a
cc6a0ef
2bbf44b
b31f9f2
b951348
520b952
b450f5e
4ea1465
cbdce2f
d2e118a
7128a28
034d3b7
9f93e5c
c320002
3e438e8
0811b2b
154ad95
66d977a
a4c292c
846039d
2f2ae47
3af49a8
944609c
e132f0d
220598b
c03f6e0
705c7b2
9e9ccb0
bd334fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should nullable being considered here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be decided during the actual computation. If there are "holes" in the output, validity buffer will be allocated and filled on demand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this explanation is confusing, but we can work on this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this change is for generate
exec_chunked
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Just slightly extending it like GenerateNumeric.