Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-27919: [CI][C++] Add a nightly job to test offline build #44721

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

kou
Copy link
Member

@kou kou commented Nov 14, 2024

Rationale for this change

If we have a nightly CI job to test offline build, we will be able to notice that offline build support is broken.

What changes are included in this PR?

  • Add the ARROW_OFFLINE option that uses cpp/thirdparty/download_dependencies.sh and disable DNS resolution
  • Add ubuntu-cpp-bundled-offline service that enable the ARROW_OFFLINE option
  • Add test-ubuntu-24.04-cpp-bundled-offline nightly job

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Nov 14, 2024

@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline

Copy link

⚠️ GitHub issue #27919 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 14, 2024
Copy link

Revision: 5c7bb69

Submitted crossbow builds: ursacomputing/crossbow @ actions-08280626f5

Task Status
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions

docker-compose.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 14, 2024
@raulcd
Copy link
Member

raulcd commented Nov 14, 2024

@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 14, 2024
Copy link

Revision: 62d877d

Submitted crossbow builds: ursacomputing/crossbow @ actions-5c885d3fff

Task Status
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions

env:
UBUNTU: 24.04
image: ubuntu-cpp-bundled-offline
timeout: 120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job took 88 minutes. Should we put the timeout to 100? 90 seems a little tight.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 120 for safety.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Nov 15, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Nov 15, 2024
@kou
Copy link
Member Author

kou commented Nov 16, 2024

@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline

Copy link

Revision: 0dc30d9

Submitted crossbow builds: ursacomputing/crossbow @ actions-4c7b9cf02c

Task Status
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions

@kou
Copy link
Member Author

kou commented Nov 17, 2024

+1

I'll merge this.

@kou kou merged commit 6427ed4 into apache:main Nov 17, 2024
44 checks passed
@kou kou removed the awaiting changes Awaiting changes label Nov 17, 2024
@kou kou deleted the ci-cpp-offline branch November 17, 2024 06:50
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6427ed4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants