-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-27919: [CI][C++] Add a nightly job to test offline build #44721
Conversation
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline |
|
Revision: 5c7bb69 Submitted crossbow builds: ursacomputing/crossbow @ actions-08280626f5
|
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline |
Revision: 62d877d Submitted crossbow builds: ursacomputing/crossbow @ actions-5c885d3fff
|
env: | ||
UBUNTU: 24.04 | ||
image: ubuntu-cpp-bundled-offline | ||
timeout: 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job took 88 minutes. Should we put the timeout to 100
? 90
seems a little tight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use 120 for safety.
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline |
Revision: 0dc30d9 Submitted crossbow builds: ursacomputing/crossbow @ actions-4c7b9cf02c
|
+1 I'll merge this. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6427ed4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
If we have a nightly CI job to test offline build, we will be able to notice that offline build support is broken.
What changes are included in this PR?
ARROW_OFFLINE
option that usescpp/thirdparty/download_dependencies.sh
and disable DNS resolutionubuntu-cpp-bundled-offline
service that enable theARROW_OFFLINE
optiontest-ubuntu-24.04-cpp-bundled-offline
nightly jobAre these changes tested?
Yes.
Are there any user-facing changes?
No.