Fix nil de ref in handleError #1845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use type-hinted-values to allow bound-values to be used outside of prepared-stmts
Perform null check before dereference
Revert "Perform null check before dereference"
|
No description, no linked issue or JIRA and the title doesn't really describe anything. Please describe the goal of this PR or this will be closed. |
|
I think the change in control.go is valid but the other changes seem out-of-scope. |
|
There's commits here from 2 years ago so to me it looks like this PR was meant for a fork or something. Again, add some description to this PR (describing issue/goal would be a good start) or mention an existing GH issue or JIRA. I'll close this until this happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.