Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-836][BUILD] Initial support sbt #1757
[CELEBORN-836][BUILD] Initial support sbt #1757
Changes from 38 commits
014dded
ed700ce
847404b
5bdc2cc
42e0893
b37570b
40396eb
dd0eb5e
aa01dd8
8da3e32
0cf7dc1
8e638b2
2996822
3cea3e4
0313dd3
19f9845
3161a8b
23b64e6
65f688d
b7db214
0dc5c83
bc9bf27
af73dae
8de82fd
e6022e2
40af990
913bdd7
55592f3
3b41963
2e6852a
9980561
5a9aa09
cb7bec1
26edf32
bc9a89e
8f16921
4b2dcea
668577e
8f21700
48a1aa9
5c8507d
960a4d5
bb161d7
fab0da0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is not the same as sbt official options, we may want to migrate it to the official one in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the file support comments? we can add comments to guide user how to use this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/questions/56343343/how-do-you-comment-in-the-sbt-repositories-file
The commenting style commences with the symbol
#
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user has configured it, include the
DEFAULT_ARTIFACT_REPOSITORY
in the list of repositories. cc @pan3793the variable substitution docs: https://www.scala-sbt.org/1.x/docs/Launcher-Configuration.html#Variable+Substitution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the variable substitution required system property instead of the environment variable, updated in 48a1aa9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for fixing it.