-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup 3] Epic: Rebrand Names and URLs for ASF Compliance #731
base: main
Are you sure you want to change the base?
Conversation
@tuhaihe How were these changes tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename only the DOC part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See attatched file: there are many matches for CloudberryDB.
cloudberrydb-search.txt
See attached file: there are many matches for "Cloudberry" by itself
cloudberry-search.txt
There is also two test failures which might be related to this PR:
- gpcopy_encoding
- dispatch_encoding
- qp_misc_rio_join_small
I can collaborate with you on running a wider test schedule list prior to committing.
Hi @edespino thanks for your feedback and support. |
aa70469
to
7c2bcd4
Compare
The terms |
I can build my changes on one docker:
However, when run the command
|
do u have make create-demo-cluster? also need export the |
Now I run
regression.out.txt I will see how to fix them next week. |
Feel free to ask engineers if you need any help. |
ab4f5d9
to
db79d34
Compare
The latest
The differences that caused some tests to fail can be viewed in the
|
Some tests failed with the error message: ‘No space left on device’. This issue seems unusual, as the test computer’s hard drive has 600GB of space, which should be sufficient. The disk usage details are as follows:
Some tests returned errors related to the latin1 encoding. These files were not modified in this pull request (PR).
For other errors, I will work with the engineering team to determine the appropriate fixes. If the errors are not introduced by this PR, I will create an issue to document them for future resolution. |
here need to enlarge shm size . |
Thanks @yjhnupt for your suggestions. I use the command to run the build docker image:
Now, after running
|
Getting closer! When running manually, I would run with one of the following. The first diff explicitly expects the orca optimizer to be set on (regardless of it being on by default). With Orca query optimizer on:
With Orca query optimizer off:
|
locale refer to : https://www.cnblogs.com/williamjie/p/9303115.html |
2cb9d44
to
f70fb0f
Compare
Thanks @edespino! It works. I ran the following two commands:
Updates: I find how to fix them. See my commit 9cf2835. Will test it locally tomorrow! |
242ddbb
to
6d973ed
Compare
Finally got it done (nearly)! I reviewed all the changes file by file this week and found a few issues then fixed them. Now all the local tests (only one failed now) based on my latest changes have passed completely! As for that Screenshots:
![]()
![]()
![]() for the failed test, haven't changed the file Update: The above failed test cannot happen again. I tested this command again on my branch and the latest main branch, another new test failed - see issue #781 My testsMy testing was based on the latest building Docker image:
Then pulling my branch:
After that, compiled and installed the Cloudberry following this guide (https://github.com/edespino/cloudberry/blob/rocky9-dev-readme/deploy/build/README-rockylinux9.md). Lastly, ran the three tests mentioned above. FYI. PlanExcept for the first two commits in this PR, most of the others are quite similar. I’m planning to squash them down into a single epic commit, and then we can start merging this PR. |
2e6af04
to
397e660
Compare
FYI: I removed the skip ci token in the PR body. This will allow the CI to run automatically on this PR. It was previously skipping. |
Thanks Ed! Now all the CI checks have passed. Do we have any plans to merge this PR? |
397e660
to
28f8726
Compare
28f8726
to
920dfd8
Compare
We are currently cherry-picking commits from the archived Greenplum repository. Since more files with legacy brand names might surface, there’s no urgency to proceed with the PR review at this stage. Once the cherry-picking is complete, I will review all the files and update the PR accordingly. |
920dfd8
to
0aa6fe0
Compare
0aa6fe0
to
2c6f202
Compare
30ed377
to
0bb92bd
Compare
This commit consolidates changes to align the project with ASF brand standards, improve clarity, and ensure consistent naming and references throughout the codebase. Key Changes: 1. Rebranding * Renamed all instances of `Cloudberry Database`, `CloudberryDB`, and similar terms to `Apache Cloudberry` or `Cloudberry` as appropriate. * Applied consistent naming across: - `contrib/*` - `gpAux/*` - `gpMgmt/*` - `gpcontrib/*` - `src/*` (e.g., src/backend, src/bin, src/include, src/test, etc.) - `doc/*` * Replace Greenplum with Apache Cloudberry in the user-facing places. 2. URL Updates * Updated outdated GitHub repository links to the new Apache project location. These changes are part of an ongoing effort to ensure ASF compliance. 3. Fix the tests to pass the checks.
9a77c66
to
8a9fead
Compare
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheck
make -C src/test installcheck-cbdb-parallel
Impact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context