Expose AO storage format checking functions for external use #954
+605
−586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that external tools such as pg_filedump does not need to copy the code in cdbappendonlystorageformat.c in order to verify checksum, get header info etc. This is done similar to storage/checksum_impl.h.
|
Just cherry-picking single commit. It ain't much, but it's honest work |
x4m
approved these changes
Feb 22, 2025
my-ship-it
reviewed
Feb 25, 2025
| static char AoHeaderCheckErrorStr[MAX_AOHEADER_CHECK_ERROR_STR] = "\0"; | ||
|
|
||
| static pg_crc32 | ||
| AppendOnlyStorageFormat_ComputeHeaderChecksum( |
There was a problem hiding this comment.
How about we declare functions as public instead of moving codes into header files, which would inline functions?
There was a problem hiding this comment.
Well, okay, lets do it this way. Notice I simply cherry-picking things, leaning toward option to keep upstream changes, which reduces cherry-pick conflicts in future (which are not very likely to occur here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that external tools such as pg_filedump does not need to copy the code in cdbappendonlystorageformat.c in order to verify checksum, get header info etc. This is done similar to storage/checksum_impl.h.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions