Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial updates to add HPE Primera and Pure Flasharray documentation #363

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Initial updates to add HPE Primera and Pure Flasharray documentation #363

merged 3 commits into from
Dec 20, 2023

Conversation

rg9975
Copy link
Contributor

@rg9975 rg9975 commented Dec 6, 2023 •
edited by github-actions bot
Loading

Providing documentation for configuration of HPE Primera and Pure Flasharray plugins targeted for 4.19.

📚 Documentation preview 📚: https://cloudstack-documentation--363.org.readthedocs.build/en/363/

shwstppr
shwstppr approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the additional whitespace changes but looks okay to me

@shwstppr
Copy link
Contributor

shwstppr commented Dec 7, 2023

@NuxRo @rajujith can you also have a quick look?

@andrijapanicsb
Copy link
Contributor

white spaces probably removed automatically, for whatever reasons, nothing broken.

I have not reviewed the HPE-specific content, as I have no knowledge on it - so I assume this is OK.

@andrijapanicsb
Copy link
Contributor

@rg9975 do you mind pls fixing these, so we can merge it?

@shwstppr shwstppr added this to the 4.19 milestone Dec 12, 2023
@rajujith
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@rajujith a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/363. (QA-JID 179)

@rajujith
Copy link
Contributor

@rg9975 the bullet points are still not formatted properly.

@shwstppr
Copy link
Contributor

@rajujith can you please check now?

@rajujith
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@rajujith a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/363. (QA-JID 181)

rajujith
rajujith approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwstppr shwstppr merged commit 3eefd9f into apache:main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrijapanicsb andrijapanicsb andrijapanicsb approved these changes

@rajujith rajujith rajujith approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19
Development

Successfully merging this pull request may close these issues.
5 participants
@rg9975 @shwstppr @andrijapanicsb @rajujith @blueorangutan