Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document advance DRS settings #374

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Document advance DRS settings #374

merged 3 commits into from
Feb 13, 2024

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Jan 18, 2024 •
edited by github-actions bot
Loading

To be merged along with apache/cloudstack#8521

📚 Documentation preview 📚: https://cloudstack-documentation--374.org.readthedocs.build/en/374/

@vishesh92 vishesh92 mentioned this pull request Jan 18, 2024
Merged
13 tasks
@vishesh92 vishesh92 closed this Jan 18, 2024
@vishesh92 vishesh92 reopened this Jan 18, 2024
kiranchavala
kiranchavala approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the drs settings description are fine

@DaanHoogland
Copy link
Contributor

@vishesh92 is this for 4.19? or next release?

@vishesh92
Copy link
Member Author

@vishesh92 is this for 4.19? or next release?

I was thinking of getting this in 4.19.1.

@vishesh92 @sureshanaparti
Update source/adminguide/clusters.rst
d6c898b 
Co-authored-by: Suresh Kumar Anaparti <[email protected]>
@vishesh92 @sureshanaparti
Apply suggestions from code review
6be13c5 
Co-authored-by: Suresh Kumar Anaparti <[email protected]>
@rohityadavcloud rohityadavcloud changed the base branch from main to 4.19 February 9, 2024 06:14
@rohityadavcloud rohityadavcloud added this to the 4.19.1 milestone Feb 9, 2024
@rohityadavcloud rohityadavcloud merged commit c4272e3 into apache:4.19 Feb 13, 2024
1 check passed
@rohityadavcloud rohityadavcloud deleted the add-advance-drs-settings branch February 13, 2024 05:49
DaanHoogland added a commit that referenced this pull request Apr 8, 2024
@DaanHoogland
Merge release branch 4.19 to main
f5fc6e7 
* 4.19:
  notes on POD-subnets (#391)
  Documentation for checkVolume API (#380)
  Document advance DRS settings (#374)
  veeam: update API commands and versions in doc (#357)
  Update virtual_machines.rst (#353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@kiranchavala kiranchavala kiranchavala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19.1
Development

Successfully merging this pull request may close these issues.
5 participants
@vishesh92 @DaanHoogland @kiranchavala @sureshanaparti @rohityadavcloud