Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: remove username required condition for listVmsForImport #9124

Merged
merged 4 commits into from
Jun 14, 2024
Merged

server: remove username required condition for listVmsForImport #9124

merged 4 commits into from
Jun 14, 2024

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented May 24, 2024 •
edited
Loading

Description

Fixes #8414

Doc changes added apache/cloudstack-documentation#401

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.95%. Comparing base (1577218) to head (e2fb453).
Report is 22 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9124      +/-   ##
============================================
- Coverage     14.96%   14.95%   -0.01%     
- Complexity    11002    11008       +6     
============================================
  Files          5373     5378       +5     
  Lines        469315   469804     +489     
  Branches      59847    58391    -1456     
============================================
+ Hits          70233    70276      +43     
- Misses       391309   391745     +436     
- Partials       7773     7783      +10
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9701

weizhouapache
weizhouapache approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache added this to the 4.19.1.0 milestone May 24, 2024
DaanHoogland
DaanHoogland approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

vishesh92
vishesh92 approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. didn't test.

@DaanHoogland DaanHoogland mentioned this pull request May 28, 2024
Merged
@DaanHoogland
Copy link
Contributor

@shwstppr as the parameters are not used, should these also be removed from the Cmd class?

@weizhouapache
Copy link
Member

@shwstppr as the parameters are not used, should these also be removed from the Cmd class?

currently vms are listed by virsh command (endpoint is the remote server)
However, it does not work in some cases (e.g. libvirt uses ssl).
username/password could be useful in the future

@vishesh92
Copy link
Member

@shwstppr Do we need any changes in the UI for this?

@andrijapanicsb
Copy link
Contributor

@vishesh92 no - those are used later during importVm API to connect via ssh etc.

@shwstppr
Copy link
Contributor Author

shwstppr commented Jun 3, 2024

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9759

@shwstppr
Copy link
Contributor Author

shwstppr commented Jun 3, 2024

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-10328)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52345 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9124-t10328-kvm-centos7.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland linked an issue Jun 4, 2024 that may be closed by this pull request
Minor: listVmsForImport API fix #8414
Closed
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9888

@vladimirpetrov vladimirpetrov self-assigned this Jun 12, 2024
vladimirpetrov
vladimirpetrov approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing - the username parameter is no longer mandatory.

@shwstppr
revert
e2fb453 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud merged commit df5c546 into apache:4.19 Jun 14, 2024
26 checks passed
@rohityadavcloud rohityadavcloud deleted the fix-listvmforimport-usernameparam branch June 14, 2024 06:45
@rohityadavcloud
Copy link
Member

Merged based on GHA smoketests and build tests.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9940

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@shwstppr @dhslove
server: remove username required condition for listVmsForImport (apac…
e6a527b 
…he#9124)

* server: remove username required condition for listVmsForImport

Fixes apache#8414

Signed-off-by: Abhishek Kumar <[email protected]>

* fix

Signed-off-by: Abhishek Kumar <[email protected]>

* revert

Signed-off-by: Abhishek Kumar <[email protected]>

---------

Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@weizhouapache weizhouapache weizhouapache approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@andrijapanicsb andrijapanicsb Awaiting requested review from andrijapanicsb

Assignees

@vladimirpetrov vladimirpetrov

Labels
None yet
Projects
ACS Backlog
Status: Abhishek's Bugfix List
Apache CloudStack 4.19.1
Status: Done
Milestone
4.19.1.0
Development

Successfully merging this pull request may close these issues.

Minor: listVmsForImport API fix
9 participants
@shwstppr @blueorangutan @DaanHoogland @weizhouapache @vishesh92 @andrijapanicsb @rohityadavcloud @sureshanaparti @vladimirpetrov