Add Checkstyle ModifierOrder

apache · Feb 9, 2025 · 281f701 · 281f701
1 parent 0368ff2
commit 281f701
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
@@ -42,6 +42,7 @@ limitations under the License.
     <module name="AvoidStarImport"/>
     <module name="RedundantImport"/>
     <module name="UnusedImports"/>
+    <module name="ModifierOrder" />
     <module name="NeedBraces"/>
     <module name="ParenPad" />
     <module name="JavadocType">

diff --git a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
@@ -292,5 +292,5 @@ private <R> R getDefaultAs(final Class<R> type) {
      * @return The converted value
      * @throws ParseException if conversion cannot be performed successfully
      */
-    abstract protected T parse(Object value, String pattern) throws ParseException;
+    protected abstract T parse(Object value, String pattern) throws ParseException;
 }
diff --git a/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java b/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java
@@ -53,7 +53,7 @@ public class BasicDynaBeanTest {
      * The set of property names we expect to have returned when calling {@code getDynaProperties()}. You should update this list when new properties are added
      * to TestBean.
      */
-    protected final static String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "floatProperty", "intArray", "intIndexed",
+    protected static final String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "floatProperty", "intArray", "intIndexed",
             "intProperty", "listIndexed", "longProperty", "mappedProperty", "mappedIntProperty", "nullProperty", "shortProperty", "stringArray",
             "stringIndexed", "stringProperty", };
 

diff --git a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java
@@ -94,7 +94,7 @@ public class PropertyUtilsTest {
      * The set of property names we expect to have returned when calling {@code getPropertyDescriptors()}. You should update this list when new properties are
      * added to TestBean.
      */
-    protected final static String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "dupProperty", "floatProperty", "intArray",
+    protected static final String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "dupProperty", "floatProperty", "intArray",
             "intIndexed", "intProperty", "listIndexed", "longProperty", "nested", "nullProperty", "readOnlyProperty", "shortProperty", "stringArray",
             "stringIndexed", "stringProperty", "writeOnlyProperty", };