[LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

[bndhanush]

NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

[garydgregory]

@bndhanush
This PR breaks the build, please see https://github.com/apache/commons-lang/pull/675/checks?check_run_id=1549559036

[bndhanush]

Hi @garydgregory,

Thank you for the notice. I have fixed the formatting issue. I see it is ok for the 16-ea build to fail, is that correct understanding?
I am pretty new to OS, can you please help me in this?

[coveralls]

Coverage decreased (-0.1%) to 94.915% when pulling 548c412 on bndhanush:master into 615eee5 on apache:master.

[garydgregory]

@chtompki
May you please validate this one?

[bndhanush]

@chtompki and @garydgregory.
Can you please help in checking if the PR is valid. Also suggest if any changes are required.

[garydgregory]

Hi @bndhanush
Thank you for your PR.
In the new test, I do not think it is enough to check that an instance of right class is created, you want to check that the right value is created to make sure we do not have the opposite issue: loosing precision.

[bndhanush]

hi @garydgregory

Thanks for the input.
I added test case to ensure that precision is not lost and we maintain the value.

Please validate the PR.