Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add & update required core repo files #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

doc: add & update required core repo files #37

wants to merge 4 commits into from

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 16, 2020

  • Added LICENSE file
  • Added NOTICE file
  • Updated CONTRIBUTING.md

@erisu erisu requested a review from NiklasMerz April 16, 2020 11:20
@brody4hire brody4hire mentioned this pull request Jun 10, 2020
Draft
1 task
@brody4hire
Copy link

Can we merge this?

timbru31
timbru31 reviewed Jun 10, 2020
View reviewed changes
timbru31
timbru31 requested changes Jun 10, 2020
View reviewed changes
@NiklasMerz NiklasMerz requested a review from timbru31 June 10, 2020 10:04
@NiklasMerz
Copy link
Member

NiklasMerz commented Jun 10, 2020 •
edited
Loading

We may need to update all repos again to push out the CONTRIBUTING file some time.

But let's get this merged get this license stuff for this repo.

timbru31
timbru31 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Should we create a new issue in apache/cordova to align the CONTRIBUTING.md files?

@brody4hire
Copy link

Should we create a new issue in apache/cordova to align the CONTRIBUTING.md files?

yes

@timbru31 timbru31 mentioned this pull request Jul 6, 2020
Open
39 tasks
@timbru31
Copy link
Member

timbru31 commented Jul 6, 2020

I've created apache/cordova#224, I think we are good to merge this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

@NiklasMerz NiklasMerz NiklasMerz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erisu @brody4hire @NiklasMerz @timbru31