Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Easy deprecation cleanups #1455

Merged
merged 5 commits into from
Aug 15, 2024
Merged

refactor!: Easy deprecation cleanups #1455

merged 5 commits into from
Aug 15, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 14, 2024

Platforms affected

iOS

Motivation and Context

Closes #1428.

Description

  • Added deprecation annotations to things we want to discourage people from using (some of these can be removed in Cordova iOS 9)
  • Remove some conditionals for iOS versions pre-11 and dead code
  • Change CDVPlugin's viewController from a UIViewController* to a CDVViewController*
  • Move a webview engine-related delegate to a header that makes more sense

Testing

Unit tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@dpogue dpogue added this to the 8.0.0 milestone Aug 14, 2024
@dpogue dpogue requested a review from erisu August 14, 2024 08:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (c8e126d) to head (7c10750).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files          16       16           
  Lines        1825     1825           
=======================================
  Hits         1430     1430           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested with:

  • Xcode 16 (beta 5) & iOS 18 (beta 5)
  • Cordova default application and confirmed that the Device is Ready is displayed.
  • Mobile spec to run against all of Apache Cordova's plugins.

@dpogue dpogue merged commit c6fd16f into apache:master Aug 15, 2024
10 checks passed
@dpogue dpogue deleted the refactor1 branch August 15, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDVPlugin's viewController should just be a CDVViewController
3 participants