Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): Update Xcode/node versions in README #1499

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 18, 2024

Platforms affected

iOS

Motivation and Context

README listed the incorrect Xcode version and incorrect xcworkspace file path for 8.x

Description

  • Updated the Xcode and node versions
  • Corrected the path to the xcworkspace file in a generated app
  • Added a link to the API docs published on GitHub pages

Testing

Previewed in GitHub

Checklist

  • I've updated the documentation if necessary

@dpogue dpogue added this to the 8.0.0 milestone Oct 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (0ddab0a) to head (7cc057c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1499   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          16       16           
  Lines        1840     1840           
=======================================
  Hits         1488     1488           
  Misses        352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue dpogue merged commit a713a0b into apache:master Oct 18, 2024
10 checks passed
@dpogue dpogue deleted the readme-updates branch October 18, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants