feat(android)!: remove unnecessary permissions #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
This PR depends on #307
fixes #289
With the removal of Media Store queries, we do not need the READ/WRITE external storage permissions.
Description
Removed several methods for managing permissions as they were not necessary. KEPT camera permission handling for that fringe case where it is required if it is declared in the manifest.
Added GRANT WRITE flag to Video/Image intents, as that is necessary to give the third-party application write access to the specified directory (as provided by our File Provider). Audio must be handled differently.
The
RECORD_SOUND_ACTION
intent does not make use of theEXTRA_OUTPUT
parameter therefore we cannot instruct the third-party application to write to a location of our choice. Instead they will always write to external storage. For consistency however, we will copy the file to the cache directory.Testing
Ran Paramedic tests.
Manual tests with and without the CAMERA permission declared on API 28 & 29.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)