-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebar3 #4120
Draft
jiahuili430
wants to merge
13
commits into
apache:main
Choose a base branch
from
jiahuili430:rebar3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rebar3 #4120
Commits on Jul 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 41c414c - Browse repository at this point
Copy the full SHA 41c414cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 789a4a1 - Browse repository at this point
Copy the full SHA 789a4a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fcad61 - Browse repository at this point
Copy the full SHA 9fcad61View commit details -
1. Removed `setup_eunit` plugin 2. Modified rebar.config.script to use correct path 3. `fauxton` is a Non-Erlang deps that rebar3 cannot fetch, so use `configure` to download
Configuration menu - View commit details
-
Copy full SHA for 6514754 - Browse repository at this point
Copy the full SHA 6514754View commit details -
1. Use `couch/rebar.config.script` to get dependencies to avoid dependency cycle errors. 2. Modify Makefile to pass `make all`
Configuration menu - View commit details
-
Copy full SHA for de9f1cc - Browse repository at this point
Copy the full SHA de9f1ccView commit details -
1. Modify `couchdb-build-releases.sh` to copy rebar3 2. Modify the path to docs
Configuration menu - View commit details
-
Copy full SHA for 18d34d2 - Browse repository at this point
Copy the full SHA 18d34d2View commit details -
1. rebar3 doesn't support `[raw]` 2. Mimic fauxton as an OTP application See apache/couchdb-fauxton@2aa7845
Configuration menu - View commit details
-
Copy full SHA for c5e4056 - Browse repository at this point
Copy the full SHA c5e4056View commit details -
rebar3: rebar3 ic setup_eunit plugin
Create a rebar3 ic setup_eunit plugin to keep the same functionality as the previous one. Since we need to use `setup_eunit.template`, so move it to `plugins/ic/priv` folder. Commands: `rebar3 help ic`, `rebar3 help ic setup_eunit`, `rebar3 ic`, `rebar3 ic setup_eunit [-f]`, `rebar3 ic setup_eunit -f`, and `make setup-eunit`
Configuration menu - View commit details
-
Copy full SHA for 098e2ad - Browse repository at this point
Copy the full SHA 098e2adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40d9ebe - Browse repository at this point
Copy the full SHA 40d9ebeView commit details -
1. Removed `-r` and `skip_apps` since rebar3 does not have them. 2. Copy `config`, `b64url`, `jiffy`, etc. to `apps` folder to avoid `application not exist in the project` error. 3. Modified paths since rebar and rebar3 used different paths. Commands: `make eunit`, `make eunit apps=config`
Configuration menu - View commit details
-
Copy full SHA for bebcbe9 - Browse repository at this point
Copy the full SHA bebcbe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b004656 - Browse repository at this point
Copy the full SHA b004656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84e4b45 - Browse repository at this point
Copy the full SHA 84e4b45View commit details
Commits on Jul 22, 2022
-
`./dev/run` is using `reltoo.config` `rebar3 release` is using `relx` For `make release`, changed `couchdb` with `start` because it's hardcoded in relx. see https://github.com/erlware/relx/blob/main/src/rlx_assemble.erl#L828
Configuration menu - View commit details
-
Copy full SHA for 2b25e38 - Browse repository at this point
Copy the full SHA 2b25e38View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.