Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky windows test #4406

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix flaky windows test #4406

wants to merge 2 commits into from

Commits on Jan 26, 2023

  1. Handle window chttpd small buffer test responses 

    On Windows it seems the sockets are closed and we get the `connection_closed`
error. Account for that error as well as a 400 or a `request_failed` response.

It behaves differently on Windows. At some point in the future investigate the
details but for now let's just bypass it.
    @nickva
    nickva committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    075d596 View commit details
    Browse the repository at this point in the history

  2. Fix flaky chttpd_changes_test 

    We made too strong of an assumption there that even in the case of Q=8 we'd
always have 2 pending changes, which is incorrect. The tests on Windows
apprently revealed an error where it returned 0. So let's relax the assumption
to assert that pending would be >= 0 and something less than 7.
    @nickva
    nickva committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    86d7ee6 View commit details
    Browse the repository at this point in the history