Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Register Spark-compatible expressions with a DataFusion context #1432

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

viczsaurav
Copy link
Contributor

Which issue does this PR close?

Closes #1365

Rationale for this change

Showcase way to register Spark-compatible expressions with a DataFusion context

What changes are included in this PR?

Test for Spark-compatible expressions registration with a DataFusion context

How are these changes tested?

➜   make test-rust 
.......
.......
Running tests/spark_expr_reg.rs (target/debug/deps/test_udf_registration-145270aaadeb5905)

running 1 test
test tests::test_udf_registration ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.48%. Comparing base (f09f8af) to head (65c8e23).
Report is 46 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1432       +/-   ##
=============================================
- Coverage     56.12%   39.48%   -16.65%     
- Complexity      976     2085     +1109     
=============================================
  Files           119      265      +146     
  Lines         11743    61639    +49896     
  Branches       2251    13102    +10851     
=============================================
+ Hits           6591    24339    +17748     
- Misses         4012    32735    +28723     
- Partials       1140     4565     +3425     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kazuyukitanimura
Copy link
Contributor

Thanks @viczsaurav looks like the format checks are failing

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viczsaurav

@andygrove andygrove merged commit 36074b4 into apache:main Feb 25, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example to spark-expr crate
4 participants