Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify-release-candidate script by removing reference to requirements-310.txt #1012

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 3, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

When verifying the release using ./dev/release/verify_release_candidate.sh 44.0.0 1 I got the following error

Requirement already satisfied: pip in ./.venv/lib/python3.11/site-packages (24.3.1)
Collecting pip
  Using cached pip-25.0-py3-none-any.whl.metadata (3.7 kB)
Using cached pip-25.0-py3-none-any.whl (1.8 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 24.3.1
    Uninstalling pip-24.3.1:
      Successfully uninstalled pip-24.3.1
Successfully installed pip-25.0
+ python3 -m pip install -r requirements-310.txt
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements-310.txt'
+ cleanup
+ '[' no = yes ']'
+ echo 'Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-python-44.0.0.XXXXX.r7zw2OmGe9 for details.'
Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-python-44.0.0.XXXXX.r7zw2OmGe9 for details.

When I commented out the line everything worked great

See the email list for more information: https://lists.apache.org/thread/gkk4lq6k19gcq9xw64mcmbxrnf68o95s

What changes are included in this PR?

Remove line that was erroring

Are there any user-facing changes?

@alamb alamb changed the title Fix verify-release-candidate script by removing requirements.txt Fix verify-release-candidate script by removing reference to requirements-310.txt Feb 3, 2025
@@ -128,7 +128,6 @@ test_source_distribution() {
python3 -m venv .venv
source .venv/bin/activate
python3 -m pip install -U pip
python3 -m pip install -r requirements-310.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add python3 -m pip install -U maturin to make the verify script work locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, we create and activate a new venv right above

Looks like requirements-310.txt was removed in #994

@alamb
Copy link
Contributor Author

alamb commented Feb 5, 2025

Thanks @kevinjqliu -- I merged your suggestion and tested that running the following passed ✅

$ ./dev/release/verify-release-candidate.sh 44.0.0 1

@alamb alamb merged commit d3c4dab into apache:main Feb 5, 2025
14 checks passed
@alamb alamb deleted the alamb/fix_verify branch February 5, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants