Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize distributed testing docs #22

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

austin362667
Copy link
Contributor

@austin362667 austin362667 commented Oct 6, 2024

The Rationales

  1. Remove redis args: It used to be that the Ray head used redis to store state and Ray workers connected to the head by referencing the address of the head's Redis server (default port 6379). Ray stopped using redis in 1.11.0 -- to make that transition less disruptive, they made it so that workers still connect to the head by referencing port :6379. source

  2. Ensure can run single node cluster on MacOS: Users might want a quick start on their own Mac dev box locally, and be aware that multi-node Ray clusters are only supported on Linux. So, I make it optional. source

  3. Hint user to simply connect to the cluster: if user already created the clusters in command line, they can just connect to it via ray.init() without specifying required resources.

Screenshot 2024-10-07 at 12 06 13 AM

docs/testing.md Outdated Show resolved Hide resolved
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austin362667

@andygrove andygrove merged commit a84eb1c into apache:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants