Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reinstate disk-based shuffle #47

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Nov 16, 2024

This PR brings back the original disk-backed shuffle (effectively reverting #19).

There is a limitation that all workers must have the same local disk (so limited to single node) but we can follow up to add a mechanism for either:

  • Using minio for shared persistence for shuffle files
  • Reading shuffle files from other nodes via Arrow Flight

@andygrove
Copy link
Member Author

I can now run TPC-H @ 100GB again:

Writing results to datafusion-ray-tpch-1731793169620.json
{
    "engine": "datafusion-python",
    "benchmark": "tpch",
    "data_path": "/mnt/bigdata/tpch/sf100",
    "query_path": "/home/andy/git/apache//datafusion-benchmarks/tpch/queries/",
    "1": [
        7.837432622909546
    ],
    "2": [
        4.042541742324829
    ],
    "3": [
        6.542836427688599
    ],
    "4": [
        2.6251494884490967
    ],
    "5": [
        11.944225072860718
    ],
    "6": [
        0.9280209541320801
    ],
    "7": [
        17.949591398239136
    ],
    "8": [
        10.611652612686157
    ],
    "9": [
        37.41403603553772
    ],
    "10": [
        9.629725456237793
    ],
    "11": [
        3.0758209228515625
    ],
    "12": [
        5.291697025299072
    ],
    "13": [
        6.631402015686035
    ],
    "14": [
        1.8772220611572266
    ],
    "15": [
        3.8080291748046875
    ],
    "16": [
        1.6926724910736084
    ],
    "17": [
        28.15924596786499
    ],
    "18": [
        28.37423038482666
    ],
    "19": [
        4.091530084609985
    ],
    "20": [
        5.51667594909668
    ],
    "21": [
        31.07892680168152
    ],
    "22": [
        1.856799602508545
    ]
}

@andygrove andygrove marked this pull request as ready for review November 16, 2024 21:44
@andygrove andygrove marked this pull request as draft November 16, 2024 22:23
@andygrove andygrove marked this pull request as ready for review November 17, 2024 00:13
@andygrove andygrove merged commit 31f8833 into apache:main Nov 19, 2024
2 checks passed
@andygrove andygrove deleted the disk-based-shuffle branch November 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant