refactor: split group_column.rs into multiple submodules #13378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2024 00:15
|
@Chen-Yuan-Lai You can run |
jayzhan211
reviewed
Nov 13, 2024
| ByteGroupValueBuilder, ByteViewGroupValueBuilder, GroupColumn, | ||
| PrimitiveGroupValueBuilder, | ||
| }; | ||
| use crate::aggregates::group_values::multi_column::byte::ByteGroupValueBuilder; |
There was a problem hiding this comment.
We prefer to merge them together
alamb
changed the title
|
@jayzhan211 thanks for your review! but the other PR (#13352) with the same issue has already been merged. @Rachelint you may need to reorganize codes again based on his change? |
Yes. |
|
#13392 -- I think has the follow on improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13262.
Rationale for this change
What changes are included in this PR?
/group_column.rsinto/multi_column/primitive.rs,/multi_column/byte.rs, and/multi_column/byte_view.rs/multi_column/mod.rsand place shared trait and function in this fileAre these changes tested?
Are there any user-facing changes?