Add support for Utf8View to string_to_array and array_to_string #13403
+365
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jayzhan211
reviewed
Nov 14, 2024
findepi
reviewed
Nov 16, 2024
# Conflicts: # datafusion/sqllogictest/test_files/string/string_view.slt
|
Do not merge - this PR does not properly handle largeutf8 and I want to try to refactor the code to reduce the # of lines of code |
|
Converting to draft while @Omega359 makes the changes described in #13403 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13383
Rationale for this change
Completing support for Utf8View in all functions.
What changes are included in this PR?
Code tests
Are these changes tested?
Yes
Are there any user-facing changes?
No