Unparse inner join with no conditions as a cross join #13460
Merged
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
approved these changes
Nov 19, 2024
|
Thanks @phillipleblanc and @alamb for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13459
Rationale for this change
This fixes the unparser to explicitly treat inner
JOINwith no conditions as aCROSS JOIN, which works for all database systems. DataFusion treats inner joins with no conditions as aCROSS JOIN- but not all database systems the unparser targets support that.What changes are included in this PR?
When generating the SQL AST for an Inner join with no conditions, return a CROSS JOIN operator instead.
Are these changes tested?
Yes
Are there any user-facing changes?
No API changes.