Avoid pushdown of volatile functions to tablescan #13475
+37
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
When using pushdown filters, the planner pushes the volatile
random()
filter to the table source, so it executes in scan (for example, in parquet) and in the query engine, which leads to weird results.Closes #13268.
Rationale for this change
It's impossible to evaluate volatile filters in different layers.
What changes are included in this PR?
Are these changes tested?
As proposed in the original issue, I tried
alltypes_tiny_pages_plain.parquet
sample file containing 7300 lines:Running a query
with
datafusion-cli
gives an answer of 726, which is pretty close to the expected 730.New plan
Before the change plan was
Are there any user-facing changes?
No breaking changes.