Remove redundant statistics from FileScanConfig #14955
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standing-Man
force-pushed
the
redundant-statistics
branch
from
f3eb12a to
c819b16
Compare
|
Looks like there are some CI issues to address Note that @blaginin fixed some issues recently, so if you merge up from main it might be better now |
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
force-pushed
the
redundant-statistics
branch
from
c819b16 to
bdfb9ac
Compare
|
i feel it may be easier if we fix #14936 first. I was planning to do it this week, but feel free to take over (just take the issue then) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Both
FileScanConfigandDataSourcehas same statistics, it make that statistics may have out-of-sync bugs.What changes are included in this PR?
Remove redundant statistics from
FileScanConfigand only a single statistics that held on theDataSource.Are these changes tested?
Are there any user-facing changes?