Weld5 needs Priority annotation on Interceptor #155
Conversation
| MyRepository myRepository = BeanProvider.getContextualReference(MyRepository.class); | ||
|
|
||
| List<String> users = myRepository.getAllUsers(); | ||
|
|
||
| Assert.assertNotNull(users); | ||
| Assert.assertEquals(3, users.size()); | ||
|
|
||
| Assert.assertSame(users, myRepository.getAllUsers()); | ||
| Assert.assertEquals(users, myRepository.getAllUsers()); |
There was a problem hiding this comment.
IMO assertSame is by design here as the result is cached - it needs to be the same object instance
There was a problem hiding this comment.
on Wildfly-managed it is not, as it seems - or else no fail.
IMHO it is up to the container to serialize/deserialize request/response objects down the interceptor chain - whatever it may be.
Iff this poses a problem, I could try to identify where this - evident? - ser/deser happens to better understand what to do.
Another possibilty would be to check for "jboss.server.name" SysProp here to capture the case.
Any decision welcome!
There was a problem hiding this comment.
There is no serialization here
The interceptor caches the method return value
If it doesnt, its still broken for weld
Therefore the exclude propably
There was a problem hiding this comment.
Is it also broken with deltaspike.bean-manager.delegate_lookup?
|
i updated the weld excludes, they are still valid thanks for your hard work on debugging all this! |
Interceptor is not visible for DeltaSpikeProxyInterceptorLookup, so Interceptor detection will fail.
By Priority annotation the visibility is elevated to application.
Further cleanup of legacy Weld-2.0 specific handling.