Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [Master] Master failover will not handle ready_stop and ready_pause workflow instance correctly. #15573

Closed
3 tasks done
ruanwenjun opened this issue Feb 5, 2024 · 0 comments · Fixed by #15572
Closed
3 tasks done

[Bug] [Master] Master failover will not handle ready_stop and ready_pause workflow instance correctly. #15573

ruanwenjun opened this issue Feb 5, 2024 · 0 comments · Fixed by #15572
Assignees
@ruanwenjun
Labels
bug Something isn't working

Comments

@ruanwenjun
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When master failover, if the workflow instance belong to the failover master is ready_stop or ready_pause, then the task instance will not be killed and the workflow instance will go into finished.

This is caused we didn't handle the ready state in failover.

What you expected to happen

The workflow instance state is correct with task instance state.

How to reproduce

  1. Kill master
  2. Stop workflow instance
  3. Restart master.

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruanwenjun ruanwenjun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the workflow instance ready state to running in failover ruanwenjun/dolphinscheduler
1 participant
@ruanwenjun