-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the workflow instance ready state to running in failover #15572
Set the workflow instance ready state to running in failover #15572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ruanwenjun If do this, the historical state added in the method processServiceImpl#constructProcessInstance
will be different from the actual one. Can I modify the command_type of Recover_Tolerance_fault_process in the method `` processServiceImpl#constructProcessInstance``` to solve this problem?
LGTM |
86df159
to
28d30a6
Compare
...er-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15572 +/- ##
=========================================
Coverage 38.52% 38.53%
- Complexity 4765 4766 +1
=========================================
Files 1305 1305
Lines 44841 44844 +3
Branches 4806 4808 +2
=========================================
+ Hits 17275 17279 +4
+ Misses 25689 25687 -2
- Partials 1877 1878 +1 ☔ View full report in Codecov by Sentry. |
fa8641f
to
d4a68cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d4a68cc
to
b812b8c
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 1b32e28)
Purpose of the pull request
close #15573
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md