Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix-14646][Worker] Fix match wrong pid on linux server #14652

Merged
merged 10 commits into from
Aug 17, 2023
Merged

[Fix-14646][Worker] Fix match wrong pid on linux server #14652

merged 10 commits into from
Aug 17, 2023

Conversation

CallMeKingsley97
Copy link
Contributor

This closes #14646

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@CallMeKingsley97 CallMeKingsley97 changed the title [DS-14646][Worker] Fix match wrong pid on linux server [Fix-14646][Worker] Fix match wrong pid on linux server Jul 28, 2023
@SbloodyS SbloodyS added 3.1.x for 3.1.x version 3.2.0 for 3.2.0 version labels Jul 28, 2023
@SbloodyS SbloodyS added this to the 3.1.8 milestone Jul 28, 2023
@SbloodyS SbloodyS added the bug Something isn't working label Jul 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #14652 (f28d976) into dev (e2b97c0) will increase coverage by 0.02%.
The diff coverage is 44.44%.

❗ Current head f28d976 differs from pull request most recent head 6949cb9. Consider uploading reports for the commit 6949cb9 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14652      +/-   ##
============================================
+ Coverage     38.69%   38.72%   +0.02%     
- Complexity     4660     4668       +8     
============================================
  Files          1287     1287              
  Lines         44238    44244       +6     
  Branches       4877     4880       +3     
============================================
+ Hits          17120    17132      +12     
+ Misses        25224    25215       -9     
- Partials       1894     1897       +3
Files Changed Coverage Δ
...nscheduler/plugin/task/api/utils/ProcessUtils.java 18.51% <44.44%> (+18.51%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CallMeKingsley97
Copy link
Contributor Author

Please run it again. Thanks @SbloodyS

@SbloodyS
Copy link
Member

SbloodyS commented Aug 4, 2023

Please run it again. Thanks @SbloodyS

Done.

@CallMeKingsley97
Copy link
Contributor Author

Please run it again. Thanks @SbloodyS

Done.

Once again, please😂

@Radeity
Copy link
Member

Radeity commented Aug 4, 2023

Hi @CallMeKingsley97 , may I ask why you separate these three test cases? It doesn't seem to cover three different OS.

@CallMeKingsley97
Copy link
Contributor Author

CallMeKingsley97 commented Aug 14, 2023 •
edited by Radeity
Loading

Hi @CallMeKingsley97 , may I ask why you separate these three test cases? It doesn't seem to cover three different OS.

Sorry, I forgot to read the reply earlier. These cases just for linux OS, in order to test different types of processes.

@zhuangchong zhuangchong modified the milestones: 3.1.8, 3.1.9 Aug 15, 2023
Radeity
Radeity approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity
Copy link
Member

Radeity commented Aug 17, 2023

Hi @Gallardot , please help check this E2E-K8S-Execute failure :D

@Gallardot
Copy link
Member

Hi @Gallardot , please help check this E2E-K8S-Execute failure :D

oops. Due to the recent release of the latest version of Kubernetes, there may be differences in the command. I will fix this issue immediately.

@Gallardot Gallardot mentioned this pull request Aug 17, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

47.1% 47.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Radeity Radeity merged commit b3af374 into apache:dev Aug 17, 2023
51 of 52 checks passed
zhongjiajie pushed a commit that referenced this pull request Aug 30, 2023
@CallMeKingsley97 @zhongjiajie
[Fix-14646][Worker] Fix match wrong pid on linux server (#14652)
22eac76 
* [DS-14646][Worker] Fix match wrong pid on linux server
This closes #14646

---------

Co-authored-by: yangxin3 <[email protected]>
(cherry picked from commit b3af374)
@zhuangchong zhuangchong modified the milestones: 3.1.9, 3.2.1 Sep 19, 2023
@cqutwangyu cqutwangyu mentioned this pull request Feb 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@Radeity Radeity Radeity approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@CallMeKingsley97 CallMeKingsley97

Labels
3.1.x for 3.1.x version 3.2.0 for 3.2.0 version backend bug Something isn't working ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

[Bug] [Worker] Match wrong pid on linux server
6 participants
@CallMeKingsley97 @codecov-commenter @SbloodyS @Radeity @Gallardot @zhuangchong