[improvement-#15268][subprocess] subprocess task cannot pass parameters which come from sub process instance #15277
Conversation
fuchanghai
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
fuchanghai
changed the title
| ProcessInstanceMap processInstanceMap = processInstanceMapDao.queryWorkProcessMapByParent( | ||
| taskExecutionContext.getProcessInstanceId(), taskExecutionContext.getTaskInstanceId()); | ||
| ProcessInstance childProcessInstance = processInstanceDao.queryById(processInstanceMap.getProcessInstanceId()); | ||
| if (!StringUtils.isBlank(childProcessInstance.getVarPool())) { |
There was a problem hiding this comment.
| if (!StringUtils.isBlank(childProcessInstance.getVarPool())) { | |
| if (StringUtils.isBlank(childProcessInstance.getVarPool())) { | |
| return taskInstanceProps | |
| } |
Please directly return if there is not varpool in sub workflow?
There was a problem hiding this comment.
hi @ruanwenjun If it is empty, it will be returned in the last line of the method。
Maybe it would be more readable if you wrote it the way you did?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15277 +/- ##
============================================
- Coverage 38.02% 37.99% -0.03%
Complexity 4692 4692
============================================
Files 1304 1305 +1
Lines 44812 44840 +28
Branches 4803 4805 +2
============================================
Hits 17038 17038
- Misses 25923 25951 +28
Partials 1851 1851 ☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed.
|
fuchanghai
force-pushed
the
fix-#15268
branch
from
1f82a7b
to
159179a
Compare
|
… from subinstance
ruanwenjun
force-pushed
the
fix-#15268
branch
from
5a3f5fd
to
c503fcf
Compare
| default List<Property> getVarPool() { | ||
| return getTaskParameters().getVarPool(); | ||
| } |
There was a problem hiding this comment.
I don't agree we need to add this method in ILogicTask, the Task SPI doesn't need to add this method, otherwise we need to add a lot of get method.
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.