Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the resource file doesn't exist message in task create page #15350

Merged
merged 9 commits into from
Dec 26, 2023
Merged

Display the resource file doesn't exist message in task create page #15350

merged 9 commits into from
Dec 26, 2023

Conversation

ly109974
Copy link
Contributor

fix #15349

2023-12-21.18.32.22.mov

@github-actions github-actions bot added the UI ui and front end related label Dec 21, 2023
@mergeable mergeable bot removed the UI ui and front end related label Dec 21, 2023
@songjianet songjianet added the UI ui and front end related label Dec 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e06999) 37.80% compared to head (e95e9a7) 37.80%.

❗ Current head e95e9a7 differs from pull request most recent head e1cb0f9. Consider uploading reports for the commit e1cb0f9 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #15350   +/-   ##
=========================================
  Coverage     37.80%   37.80%           
  Complexity     4681     4681           
=========================================
  Files          1304     1304           
  Lines         44937    44937           
  Branches       4812     4812           
=========================================
  Hits          16990    16990           
  Misses        26098    26098           
  Partials       1849     1849

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ly109974
Copy link
Contributor Author

image
image
optimize adjusted

@ly109974
Copy link
Contributor Author

@songjianet Please take a look

@ruanwenjun ruanwenjun changed the title fix resource bug Display the resource doesn't exist in task create page Dec 23, 2023
@ruanwenjun ruanwenjun changed the title Display the resource doesn't exist in task create page Display the resource file doesn't exist message in task create page Dec 23, 2023
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Dec 25, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 26, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zhuangchong zhuangchong merged commit c849501 into apache:dev Dec 26, 2023
54 checks passed
@ly109974 ly109974 deleted the dev-resource branch December 26, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songjianet songjianet songjianet approved these changes

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@ly109974 ly109974

Labels
improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Workflow Definition] [UI] Non-existent resource front ends cannot be culled
6 participants
@ly109974 @codecov-commenter @songjianet @ruanwenjun @zhuangchong @davidzollo