-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][HTTP] support customization of the JSON format in http body #15531
Conversation
Signed-off-by: Gallardot <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15531 +/- ##
=========================================
Coverage 38.15% 38.15%
- Complexity 4705 4708 +3
=========================================
Files 1304 1304
Lines 44820 44828 +8
Branches 4805 4807 +2
=========================================
+ Hits 17099 17106 +7
Misses 25870 25870
- Partials 1851 1852 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. That's great! Thanks.
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Signed-off-by: Gallardot <[email protected]> Co-authored-by: Eric Gao <[email protected]>
[Improvement][HTTP] support custom rendering of http body (apache#15531) See merge request logan/devops/apache/dolphinscheduler!19
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md